Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chunking bug with compound dtypes #1146

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

pauladkisson
Copy link
Member

@pauladkisson pauladkisson commented Nov 22, 2024

Fixes #1122

Comapare Dev Tests after the fix: https://github.com/catalystneuro/neuroconv/actions/runs/12171065620/job/33947262987

To Dev Tests before: https://github.com/catalystneuro/neuroconv/actions/runs/12152927667/job/33890176686 (774 failed)

Edit: Still have work to do based on the errors in the new dev tests

@pauladkisson pauladkisson marked this pull request as ready for review December 5, 2024 00:48
@pauladkisson pauladkisson requested a review from rly December 5, 2024 00:50
@pauladkisson
Copy link
Member Author

@rly, lmk what you think

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.59%. Comparing base (96dfdff) to head (72f49c0).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
..._helpers/_configuration_models/_base_dataset_io.py 91.89% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1146      +/-   ##
==========================================
- Coverage   90.69%   89.59%   -1.10%     
==========================================
  Files         129      129              
  Lines        8189     8394     +205     
==========================================
+ Hits         7427     7521      +94     
- Misses        762      873     +111     
Flag Coverage Δ
unittests 89.59% <92.50%> (-1.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...roconv/tools/nwb_helpers/_dataset_configuration.py 93.67% <100.00%> (+0.16%) ⬆️
..._helpers/_configuration_models/_base_dataset_io.py 95.59% <91.89%> (-1.18%) ⬇️

... and 21 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Recommended Chunk Shape doesn't take into account compound dtypes
1 participant