-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing typing to NWBConverter
backend and backend options
#1160
Conversation
NWBConverter
backend and backend options
@@ -159,8 +159,8 @@ def assertNWBFileStructure(self, nwbfile_path: str): | |||
nwbfile = io.read() | |||
|
|||
self.assertEqual( | |||
nwbfile.session_start_time, | |||
datetime(2021, 10, 7, 15, 3, 28, 635).astimezone(), | |||
nwbfile.session_start_time.replace(tzinfo=None), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, I didn't think about that this can cause issues. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one small typo. Thanks!
Co-authored-by: Szonja Weigl <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1160 +/- ##
==========================================
+ Coverage 90.69% 90.75% +0.06%
==========================================
Files 129 129
Lines 8189 8286 +97
==========================================
+ Hits 7427 7520 +93
- Misses 762 766 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Running local tests for the next release I noticed and changed three things: