Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing typing to NWBConverter backend and backend options #1160

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented Dec 16, 2024

Running local tests for the next release I noticed and changed three things:

  1. The converter was missing the zarr option in the signature for typing. I added the typing and modified the docstring accordingly.
  2. The miniscope tests were comparing session start time with time zone included. This only works on the CI but fails locally if someone is not in the time zone of the CI server. I made the comparison on the naive datetime object only.
  3. The TDT interface for fiber photometry is outputting files on the repo directory. I changed the conversion gallery so it uses the same machinery as all the other interfaces (where the output of the gallery is written to a temporary directory).

@h-mayorquin h-mayorquin changed the title Add missing typing typing to converter backend options Add missing typing to NWBConverter backend and backend options Dec 16, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review December 17, 2024 14:53
@@ -159,8 +159,8 @@ def assertNWBFileStructure(self, nwbfile_path: str):
nwbfile = io.read()

self.assertEqual(
nwbfile.session_start_time,
datetime(2021, 10, 7, 15, 3, 28, 635).astimezone(),
nwbfile.session_start_time.replace(tzinfo=None),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, I didn't think about that this can cause issues. Thanks!

Copy link
Contributor

@weiglszonja weiglszonja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small typo. Thanks!

@h-mayorquin h-mayorquin enabled auto-merge (squash) December 19, 2024 16:10
@h-mayorquin h-mayorquin merged commit 74ca5b8 into main Dec 19, 2024
40 checks passed
@h-mayorquin h-mayorquin deleted the more_fixes_before_release branch December 19, 2024 19:17
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (96dfdff) to head (4dd1cd6).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1160      +/-   ##
==========================================
+ Coverage   90.69%   90.75%   +0.06%     
==========================================
  Files         129      129              
  Lines        8189     8286      +97     
==========================================
+ Hits         7427     7520      +93     
- Misses        762      766       +4     
Flag Coverage Δ
unittests 90.75% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/neuroconv/nwbconverter.py 94.96% <ø> (ø)

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants