Silence -Weffc++ compiler warnings from gcc 11.4 #2945
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't ready yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes either address or silence the warnings that come from using -Weffc++ with gcc. This code has to be compiled in other projects, and it's easier to use this option if Catch isn't filling the compilation logs with warnings in its code, especially the headers. This compiler option has helped me in the past to find a subtle bug, and I'd like to continue doing that. Using this compiler option can also help highlight what does need to be tested.
The warnings about the operators were silenced with these changes because they seem like basic functionality. The rest were addressed as best that I can address them.
GitHub Issues
This addresses the
-Weffc++part of #2927.