Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust SDK framework for CC API VM SDK [Ready to Merge] #31

Merged
merged 13 commits into from
Jan 11, 2024
Merged

Rust SDK framework for CC API VM SDK [Ready to Merge] #31

merged 13 commits into from
Jan 11, 2024

Conversation

hairongchen
Copy link
Contributor

@hairongchen hairongchen commented Dec 25, 2023 •
edited
Loading

This PR build a framework to:

  • build a common trusted base for TEEs and implemented TDX as first supported TEE in the trusted base
  • build CC trusted API SDK to support get_cc_report for TDX case and build help tools to dump cc report
  • define APIs and data structures for TCG spec and TEE interface
  • a sample to get and dump TDX quote via CC trusted API get_cc_report
  • make sure crate cctrusted_base will not use any std crate so that it can be used in scenario with no OS

@kenplusplus kenplusplus changed the title Rust SDK framework for CC API VM SDK Rust SDK framework for CC API VM SDK [Need More Update, Not Merge Now) Dec 26, 2023
@kenplusplus kenplusplus changed the title Rust SDK framework for CC API VM SDK [Need More Update, Not Merge Now) Rust SDK framework for CC API VM SDK [Need More Update, Not Merge Now] Dec 26, 2023
@kenplusplus kenplusplus changed the title Rust SDK framework for CC API VM SDK [Need More Update, Not Merge Now] Rust SDK framework for CC API VM SDK [Not Merge Now] Dec 26, 2023
hairongchen and others added 10 commits December 28, 2023 09:52
@hairongchen
This commit fix follows:
254da52 
1. update crate common/cctrusetd_base does not depend on std crates
2. change crate name from cctrusted to cctrusted_vm for VM SDK to in-sync with Python latest update
3. define trait CCTrustedApi in crate common/cctrusetd_base to define general cc trusted APIs
4. change api to sdk concept in cctrusted_vm crate
5. move CVM related functions to cctrusted_vm crate
6. update TCG algo list to reflact review comments by Jiewen
@hairongchen
Merge branch 'cc-api:main' into rust_sdk_framework
2c013b5
@hairongchen
updates according to review comments:
3237aa3 
- add github action for rust check
- add license and lincense check
- update code format according to rust code check feedback
@hairongchen
rust github action: update rust toolchain
c18b69a
@hairongchen
refine rust check github action
ecb4b30
@hairongchen
refine the action
a760f1d
@hairongchen
update runner
4e151e6
@hairongchen
update code format according to rust code scan report
f368ead
@hairongchen
update cargo base work dir
b9accb6
@hairongchen
add check for VM SDK
3f3fc3c
@hairongchen hairongchen changed the title Rust SDK framework for CC API VM SDK [Not Merge Now] Rust SDK framework for CC API VM SDK [Ready to Merge] Jan 11, 2024
kenplusplus
kenplusplus approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@kenplusplus kenplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenplusplus kenplusplus merged commit 490259d into cc-api:main Jan 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyao1 jyao1 jyao1 left review comments

@kenplusplus kenplusplus kenplusplus approved these changes

@wenhuizhang wenhuizhang Awaiting requested review from wenhuizhang

@dongx1x dongx1x Awaiting requested review from dongx1x

@Ruoyu-y Ruoyu-y Awaiting requested review from Ruoyu-y

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hairongchen @wenhuizhang @jyao1 @kenplusplus