Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ miscellaneous changes pulled from #622 #669

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Conversation

burgholzer
Copy link
Member

Description

This PR pulls out a couple of changes from #662 that can go into the library immediately, while that PR is still in draft.
Mostly fixes a couple of linter/compiler warnings and improves the handling of Boost / boost_multiprecision.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

* shorten the name to `boost_mp`
* do not use system boost by default
* require finding boost when opting for system boost

Signed-off-by: burgholzer <[email protected]>
@burgholzer burgholzer added refactor Anything related to code refactoring Core Anything related to the Core library and IR c++ Anything related to C++ code labels Aug 13, 2024
@burgholzer burgholzer self-assigned this Aug 13, 2024
@burgholzer burgholzer enabled auto-merge August 13, 2024 21:33
@burgholzer burgholzer merged commit 942dd6a into main Aug 13, 2024
30 checks passed
@burgholzer burgholzer deleted the extract-from-662 branch August 13, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code Core Anything related to the Core library and IR refactor Anything related to code refactoring
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant