Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix permutation handling in QASM dump #810

Merged
merged 2 commits into from
Jan 22, 2025
Merged

🐛 fix permutation handling in QASM dump #810

merged 2 commits into from
Jan 22, 2025

Conversation

burgholzer
Copy link
Member

Description

This PR fixes an oversight in #753 where the respective changes would sometimes create invalid output permutation dumps.
This surfaced as part of cda-tum/mqt-qmap#418.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer self-assigned this Jan 22, 2025
@burgholzer burgholzer added fix Fix for something that isn't working Core Anything related to the Core library and IR c++ Anything related to C++ code labels Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.2%. Comparing base (5959931) to head (b712d27).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #810   +/-   ##
=====================================
  Coverage   92.2%   92.2%           
=====================================
  Files        126     126           
  Lines      13830   13832    +2     
  Branches    2153    2153           
=====================================
+ Hits       12760   12763    +3     
+ Misses      1070    1069    -1     
Flag Coverage Δ
cpp 92.0% <100.0%> (+<0.1%) ⬆️
python 99.7% <ø> (ø)
Files with missing lines Coverage Δ
src/ir/QuantumComputation.cpp 90.4% <100.0%> (+<0.1%) ⬆️

... and 1 file with indirect coverage changes

@burgholzer burgholzer enabled auto-merge (squash) January 22, 2025 13:13
@burgholzer burgholzer merged commit ca1e4c4 into main Jan 22, 2025
31 checks passed
@burgholzer burgholzer deleted the fix-qasm-dump branch January 22, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code Core Anything related to the Core library and IR fix Fix for something that isn't working
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant