Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ combine builds for emulated wheels #22

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

burgholzer
Copy link
Member

Instead of 3 * |supported python versions| jobs, this will only create 3 jobs to build wheels on platforms that need emulation. Tools running this workflow and are using scikit-build-core as a build backend, should set

[tool.scikit-build]
# ...
build-dir = "build/{build_type}"
# ...

so that the build directory can be reused across builds. This only requires the actual binding target to be recompiled.
There is a very slim chance that this needs to be reverted or refactored if it turns out that the MQT QMAP builds exceed the six hour GitHub limit.

Tools should also set

[tool.cibuildwheel.windows]
# ...
environment = { SKBUILD_CMAKE_ARGS="--fresh" }
# ...

to avoid problems with old link settings remaining in the CMake cache on Windows.

Instead of `3 * |supported python versions|` jobs, this will only create `3` jobs to build wheels on platforms that need emulation.
Tools running this workflow and are using scikit-build-core as a build backend, should set

```toml
[tool.scikit-build]
# ...
build-dir = "build/{build_type}"
# ...
```

so that the build directory can be reused across builds. This only requires the actual binding target to be recompiled.

It is recommended to also set
```toml
[tool.cibuildwheel.windows]
# ...
environment = { SKBUILD_CMAKE_ARGS="--fresh" }
# ...
```

to avoid problems on Windows.
@burgholzer burgholzer added continuous integration Anything related to the CI setup enhancement Improvement of an existing feature or request github_actions Pull requests that update Github_actions code python Anything related to Python code labels Aug 9, 2024
@burgholzer burgholzer self-assigned this Aug 9, 2024
@burgholzer burgholzer added the minor Part of a minor release label Aug 9, 2024
@burgholzer burgholzer merged commit 7047b80 into main Aug 9, 2024
2 checks passed
@burgholzer burgholzer deleted the combined-emulated-wheels branch August 9, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Anything related to the CI setup enhancement Improvement of an existing feature or request github_actions Pull requests that update Github_actions code minor Part of a minor release python Anything related to Python code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant