Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️🪝 update pre-commit hooks #58

Merged
merged 2 commits into from
Dec 6, 2023
Merged

⬆️🪝 update pre-commit hooks #58

merged 2 commits into from
Dec 6, 2023

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Dec 4, 2023

@pre-commit-ci
⬆️🪝 update pre-commit hooks
cf3104e 
updates:
- [github.com/pre-commit/mirrors-clang-format: v17.0.5 → v17.0.6](pre-commit/mirrors-clang-format@v17.0.5...v17.0.6)
- [github.com/pre-commit/mirrors-prettier: v3.1.0 → v4.0.0-alpha.3](pre-commit/mirrors-prettier@v3.1.0...v4.0.0-alpha.3)
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a46d451) 84.2% compared to head (6ae4dcb) 84.2%.

Additional details and impacted files 
@@          Coverage Diff          @@
##            main     #58   +/-   ##
=====================================
  Coverage   84.2%   84.2%           
=====================================
  Files         25      25           
  Lines       4913    4913           
  Branches     595     595           
=====================================
  Hits        4137    4137           
  Misses       776     776

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

burgholzer
burgholzer approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just don't forget to remove the temporary workaround once it is no longer needed in a future update 👍🏼

@sengels-tum sengels-tum merged commit 423fe3e into main Dec 6, 2023
10 checks passed
@sengels-tum sengels-tum deleted the pre-commit-ci-update-config branch December 6, 2023 11:09
@sengels-tum sengels-tum mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burgholzer burgholzer burgholzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burgholzer @sengels-tum