Feature/blocker comments #403
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jutoft hey and thanks for this! Just getting back from vacation now and looking over things. Anything else we want to do here? |
|
The changes works for what we use the api for. There is more deprecations, but i have not looked into them. |
|
@jutoft thanks! I'll play with this a bit to make sure everything still works. This is a pretty big PR and breaking things up would certainly be better if you had the time (i.e. by feature/API) but I'll attempt to go through and see what I can make happen. |
cdancy
reviewed
Nov 28, 2023
| @PathParam("pullRequestId") long pullRequestId, | ||
| @Nullable @QueryParam("limit") Integer limit, | ||
| @Nullable @QueryParam("start") Integer start, | ||
| // @Nullable @QueryParam("count") Boolean count, |
There was a problem hiding this comment.
no it was not, the api is kind of strange in that the input completely changes the output format returned.
so adding count i think changed what was returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were done to support running on bitbucket 8.x
closes #402
closes #306