Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clerk-js w/ npm auto-update #1939

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add clerk-js w/ npm auto-update #1939

wants to merge 2 commits into from

Conversation

Kshao123
Copy link

@Kshao123 Kshao123 commented Dec 26, 2024 •
edited
Loading

MattIPv4
MattIPv4 requested changes Jan 1, 2025
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Please take a look at the CI errors -- you need an authors array instead of an author object, and repository.directory is not a property we support.

Also, I think it might be more sensible to name this clerk-js rather than clerk-clerk-js?

@Kshao123 Kshao123 changed the title Add clerk-clerk-js w/ npm auto-update Add clerk-js w/ npm auto-update Jan 2, 2025
@Kshao123 Kshao123 requested a review from MattIPv4 January 8, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 Awaiting requested review from MattIPv4

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kshao123 @MattIPv4