Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-add operations_aws_production database #114

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

patheard
Copy link
Member

Summary

Re-add the Operations AWS production database which was accidentally deleted while adding the Platform Support production database.

Related

Re-add the Operations AWS production database which was accidentally deleted
while adding the Platform Support production database.
@patheard patheard self-assigned this Jan 21, 2025
Copy link
Contributor

Production: glue 🧴

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 0 to add, 1 to change, 0 to destroy
Show summary
CHANGE NAME
update aws_glue_resource_policy.cross_account_access
Show plan
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # aws_glue_resource_policy.cross_account_access will be updated in-place
  ~ resource "aws_glue_resource_policy" "cross_account_access" {
        id     = "ca-central-1"
      ~ policy = jsonencode(
          ~ {
              ~ Statement = [
                    # (2 unchanged elements hidden)
                    {
                        Action    = [
                            "glue:GetTables",
                            "glue:GetTableVersions",
                            "glue:GetTableVersion",
                            "glue:GetTable",
                            "glue:GetPartitions",
                            "glue:GetPartition",
                            "glue:GetDatabases",
                            "glue:GetDatabase",
                            "glue:BatchGetPartition",
                        ]
                        Effect    = "Allow"
                        Principal = {
                            AWS = "arn:aws:iam::257394494478:role/SupersetAthenaRead-platform_gc_forms_production"
                        }
                        Resource  = [
                            "arn:aws:glue:ca-central-1:739275439843:table/platform_gc_forms_production/*",
                            "arn:aws:glue:ca-central-1:739275439843:database/platform_gc_forms_production",
                            "arn:aws:glue:ca-central-1:739275439843:catalog",
                        ]
                        Sid       = "SupersetReadAccessPlatformGcFormsProduction"
                    },
                  + {
                      + Action    = [
                          + "glue:GetTables",
                          + "glue:GetTableVersions",
                          + "glue:GetTableVersion",
                          + "glue:GetTable",
                          + "glue:GetPartitions",
                          + "glue:GetPartition",
                          + "glue:GetDatabases",
                          + "glue:GetDatabase",
                          + "glue:BatchGetPartition",
                        ]
                      + Effect    = "Allow"
                      + Principal = {
                          + AWS = "arn:aws:iam::257394494478:role/SupersetAthenaRead-platform_support_production"
                        }
                      + Resource  = [
                          + "arn:aws:glue:ca-central-1:739275439843:table/platform_support_production/*",
                          + "arn:aws:glue:ca-central-1:739275439843:database/platform_support_production",
                          + "arn:aws:glue:ca-central-1:739275439843:catalog",
                        ]
                      + Sid       = "SupersetReadAccessPlatformSupportProduction"
                    },
                ]
                # (1 unchanged attribute hidden)
            }
        )
    }

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"
Show Conftest results
WARN - plan.json - main - Missing Common Tags: ["aws_glue_catalog_database.operations_aws_production"]
WARN - plan.json - main - Missing Common Tags: ["aws_glue_catalog_database.operations_aws_production_raw"]
WARN - plan.json - main - Missing Common Tags: ["aws_glue_catalog_database.platform_gc_forms_production"]
WARN - plan.json - main - Missing Common Tags: ["aws_glue_catalog_database.platform_support_production"]
WARN - plan.json - main - Missing Common Tags: ["aws_glue_catalog_database.platform_support_production_raw"]
WARN - plan.json - main - Missing Common Tags: ["aws_glue_crawler.operations_aws_production_account_tags"]
WARN - plan.json - main - Missing Common Tags: ["aws_glue_crawler.operations_aws_production_cost_usage_report"]
WARN - plan.json - main - Missing Common Tags: ["aws_glue_crawler.platform_gc_forms_forms_production"]
WARN - plan.json - main - Missing Common Tags: ["aws_glue_crawler.platform_support_freshdesk_production"]
WARN - plan.json - main - Missing Common Tags: ["aws_glue_job.forms_generate_test_data"]
WARN - plan.json - main - Missing Common Tags: ["aws_glue_job.platform_support_freshdesk"]
WARN - plan.json - main - Missing Common Tags: ["aws_glue_trigger.platform_support_freshdesk"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.glue_crawler"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.glue_etl"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.glue_crawler"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.glue_etl"]
WARN - plan.json - main - Missing Common Tags: ["aws_kms_key.aws_glue"]
WARN - plan.json - main - Missing Common Tags: ["aws_s3_object.forms_generate_test_data"]
WARN - plan.json - main - Missing Common Tags: ["aws_s3_object.platform_support_freshdesk_job"]
WARN - plan.json - main - Missing Common Tags: ["aws_s3_object.platform_support_freshdesk_requirements"]

39 tests, 19 passed, 20 warnings, 0 failures, 0 exceptions

@patheard patheard requested a review from a team January 21, 2025 17:46
@patheard patheard merged commit a00e796 into main Jan 21, 2025
4 checks passed
@patheard patheard deleted the fix/database-name-removal branch January 21, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants