Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reword Glue Job failure alarm description #41

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

patheard
Copy link
Member

Summary

The previous description was triggering the SRE Bot's CloudWatch error metric filter alarm.

The previous description was triggering the SRE Bot's CloudWatch
error metric filter alarm.
@patheard patheard self-assigned this Nov 21, 2024
@patheard patheard requested a review from a team November 21, 2024 16:08
Copy link
Contributor

Production: alarms 🚨

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 0 to add, 1 to change, 0 to destroy
Show summary
CHANGE NAME
update aws_cloudwatch_metric_alarm.glue_job_failures
Show plan
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # aws_cloudwatch_metric_alarm.glue_job_failures will be updated in-place
  ~ resource "aws_cloudwatch_metric_alarm" "glue_job_failures" {
      ~ alarm_description                     = "Glue Job state has changed to `FAILURE`, `TIMEOUT` or `ERROR`." -> "Glue Job state has changed to `Failure`, `Timeout` or `Error`."
        id                                    = "glue-job-failures"
        tags                                  = {}
        # (21 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"
Show Conftest results
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_event_rule.glue_job_failure"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.glue_crawler_error"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.glue_job_failures"]
WARN - plan.json - main - Missing Common Tags: ["aws_kms_key.cloudwatch"]
WARN - plan.json - main - Missing Common Tags: ["aws_sns_topic.cloudwatch_alarm_action"]
WARN - plan.json - main - Missing Common Tags: ["aws_sns_topic.cloudwatch_ok_action"]

25 tests, 19 passed, 6 warnings, 0 failures, 0 exceptions

@patheard patheard merged commit a4ad747 into main Nov 21, 2024
4 checks passed
@patheard patheard deleted the chore/reword-alarm branch November 21, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants