Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: partition Freshdesk ticket by month #98

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

patheard
Copy link
Member

@patheard patheard commented Jan 14, 2025

Summary

  1. Update the Freshdesk ticket export so that it partitions data by month. Additionally, avoid saving tickets if there are none returned for the given day.
  2. Check for paged results when retrieving tickets.
  3. Update the Glue crawler table prefix so that the final table name is platform_support_freshdesk.

Related

Update the Freshdesk ticket export so that it partitions data by month.
Additionally, avoid saving tickets if there are none returned for the given day.

Update the Glue crawler table prefix.
@patheard patheard self-assigned this Jan 14, 2025
@patheard patheard requested a review from a team January 14, 2025 21:15
@patheard patheard force-pushed the fix/freshdesk-export-partition branch from 4c4b07f to 647dfb7 Compare January 14, 2025 21:28
@patheard patheard enabled auto-merge (squash) January 14, 2025 22:14
Copy link
Contributor

Production: export 💾

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 0 to add, 1 to change, 0 to destroy
Show summary
CHANGE NAME
update module.platform_support_freshdesk_export.module.platform_support_freshdesk_export.module.this_lambda.aws_lambda_function.this
Show plan
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.platform_support_freshdesk_export.module.platform_support_freshdesk_export.module.this_lambda.aws_lambda_function.this will be updated in-place
  ~ resource "aws_lambda_function" "this" {
        id                             = "platform-support-freshdesk-export"
        tags                           = {
            "CostCentre" = "PlatformDataLake"
            "Terraform"  = "true"
        }
      ~ timeout                        = 15 -> 300
        # (27 unchanged attributes hidden)

        # (4 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"
Show Conftest results
WARN - plan.json - main - Missing Common Tags: ["module.platform_support_freshdesk_export.aws_cloudwatch_metric_alarm.platform_support_freshdesk_export"]
WARN - plan.json - main - Missing Common Tags: ["module.platform_support_freshdesk_export.aws_ssm_parameter.freshdesk_api_key"]

21 tests, 19 passed, 2 warnings, 0 failures, 0 exceptions

@patheard patheard merged commit 26f80d4 into main Jan 15, 2025
5 checks passed
@patheard patheard deleted the fix/freshdesk-export-partition branch January 15, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants