Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev: Details component + Link component Figma fixes #1147

Closed
11 tasks done
adorayi opened this issue Sep 17, 2024 · 2 comments
Closed
11 tasks done

Dev: Details component + Link component Figma fixes #1147

adorayi opened this issue Sep 17, 2024 · 2 comments
Assignees
@melaniebmn
Labels
development Development tasks For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint High Priority | Haute priorité

Comments

@adorayi
Copy link
Contributor

adorayi commented Sep 17, 2024 •
edited by melaniebmn
Loading

📇 User story

  • As a GCDS Components developer, I want to have the coded components for Link and Details aligned with their corresponding designs in figma

✅ Definition of Done / Outcomes

📜 Acceptance criteria

  • Link: Mobile Link font token is set to 16px, 150% line height
  • Mobile link size: textMobile
  • Link: Spacing between text and icon on desktop is increased from 3px to 6px
  • Link: Figma file
  • Details: Mobile Link font token is set to 16px, 150% line height
  • Details mobile link size: textMobile
  • Details: Spacing matches design
  • Details: Figma file
@adorayi adorayi added For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint High Priority | Haute priorité labels Sep 17, 2024
@adorayi adorayi changed the title Copy of Details component + Link Figma fixes Dev: Details component + Link Figma fixes Sep 17, 2024
@daine daine added the development Development tasks label Oct 1, 2024
@daine daine mentioned this issue Oct 2, 2024
Open
4 tasks
@melaniebmn melaniebmn self-assigned this Oct 3, 2024
@ClementineHahn ClementineHahn changed the title Dev: Details component + Link Figma fixes Dev: Details component + Link component Figma fixes Oct 3, 2024
@ClementineHahn
Copy link
Collaborator

Might need designer review after

@daine
Copy link
Collaborator

daine commented Nov 25, 2024

Released v0.27.0

@daine daine closed this as completed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melaniebmn melaniebmn

Labels
development Development tasks For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint High Priority | Haute priorité
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@daine @melaniebmn @ClementineHahn @adorayi @RavinaSamaroo