Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish: Details component + Link Figma fixes #1172

Open
4 tasks
adorayi opened this issue Sep 25, 2024 · 1 comment
Open
4 tasks

Publish: Details component + Link Figma fixes #1172

adorayi opened this issue Sep 25, 2024 · 1 comment
Labels
development Development tasks For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint High Priority | Haute priorité

Comments

@adorayi
Copy link
Contributor

adorayi commented Sep 25, 2024 •
edited by daine
Loading

Links:

  • Apply mobile link font token - 16px, 150% line height
  • Increase spacing between text and icon on desktop from 3px to 6px
    Figma file

Details component:

  • Use mobile link font token - 16px, 150% line height
  • Ensure spacing matches Figma file

Requires:
@adorayi adorayi added For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint High Priority | Haute priorité labels Sep 25, 2024
@adorayi adorayi changed the title Copy of Dev: Details component + Link Figma fixes Publish: Details component + Link Figma fixes Sep 25, 2024
@daine daine added the development Development tasks label Oct 1, 2024
@daine daine mentioned this issue Oct 2, 2024
Closed
11 tasks
@daine
Copy link
Collaborator

daine commented Nov 26, 2024 •
edited
Loading

The design and dev parts have been published, but, upon design review, the details and link fonts seem to still be using the desktop sizing rather than the smaller mobile font. This is most likely due to the changes not being applied on the documentation website yet so a full review isn't possible.

This needs to be revisited once we have published the typography changes and updated the documentation website,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
development Development tasks For Grooming Issues with this label will be prioritized in the next team grooming session and likely next sprint High Priority | Haute priorité
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daine @adorayi @RavinaSamaroo