Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create release_card_template #1170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ClementineHahn
Copy link
Collaborator

Creation of a new template so we can create release card for component and improve sync of deliveries as highlighted in our new workflow

Summary | Résumé

1-3 sentence description of the changed you're proposing, including a link to
a GitHub Issue # or Trello card if applicable.


Description en 1 à 3 phrases de la modification proposée, avec un lien vers le
problème (« issue ») GitHub ou la fiche Trello, le cas échéant.

Test instructions | Instructions pour tester la modification

Sequential steps (1., 2., 3., ...) that describe how to test this change. This
will help a developer test things out without too much detective work. Also,
include any environmental setup steps that aren't in the normal README steps
and/or any time-based elements that this requires.


Étapes consécutives (1., 2., 3., …) qui décrivent la façon de tester la
modification. Elles aideront les développeurs à faire des tests sans avoir à
jouer au détective. Veuillez aussi inclure toutes les étapes de configuration
de l’environnement qui ne font pas partie des étapes normales dans le fichier
README et tout élément temporel requis.

Creation of a new template so we can create release card for component and improve sync of deliveries as highlighted in our new workflow

---

**Summary:** Release of the XXXX component.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about hoping to continue using a user story format. That format improves clarity of the work as well as gives visibility into the value it brings to the user

Copy link
Collaborator

@daine daine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a few suggestions based on recent tickets we've had regarding publishing. Here's a few example tickets I based my review on:
#1137
#1132

**Summary:** Release of the XXXX component.
When build dev/design and content are all synced and requirements and decisions are documented, we're ready to release component on all touch points.

*Ddefinition of done:**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*Ddefinition of done:**
## ✅ Definition of Done / Outcomes

Comment on lines +14 to +19
- [ ]Merge figma work to main and publish library
- [ ]Component package is released
- [ ]Publish new component on documentation website
- [ ]Related updates to other component pages are made, as needed
- [ ]Inform engagement team of upcoming release
- [ ]Publish a release info on slack
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Done when design has merged the component in figma
  • Done when development has merged the PR r
  • Done when development has released the package(s)
  • Done when the website has been updated with documentation for the guidance
  • Done when a release message has been posted on slack
  • Done when engagement team is informed of the release

Comment on lines +27 to +33
**Deliverables:**
- [ ]Component code added to Github repository
- [ ]Changelog
- [ ]EN component page, poster, and assets available on Figma
- [ ]FR component page, poster, and assets available on Figma
- [ ]EN guidance is published to the website
- [ ]FR guidance is published to the website
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Deliverables:**
- [ ]Component code added to Github repository
- [ ]Changelog
- [ ]EN component page, poster, and assets available on Figma
- [ ]FR component page, poster, and assets available on Figma
- [ ]EN guidance is published to the website
- [ ]FR guidance is published to the website

I believe we can remove this portion too. For example, CHANGELOG is just a part of our process especially since we automated its creation through release please (and we review it prior to release)

Comment on lines +21 to +25
**Acceptance criteria:**
- [ ]potential breaking changes were identified
- [ ]If breaking changes > creation of dedicated card to create specific content
- [ ]Component has been added or updated on the holidays example app
- [ ]Component has zero accesibility violation on storybook
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Acceptance criteria:**
- [ ]potential breaking changes were identified
- [ ]If breaking changes > creation of dedicated card to create specific content
- [ ]Component has been added or updated on the holidays example app
- [ ]Component has zero accesibility violation on storybook
## 📜 Acceptance criteria
- [ ] Design ticket is finalized and ready for merge
- [ ] Develop ticket is finalized and ready for merge
- [ ] Documentation ticket is finalized and ready for publishing
- [ ] Content ticket is finalized and ready for publishing


---

**Summary:** Release of the XXXX component.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we can add something here that says "Use the title format Publish: for this type of ticket"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants