Skip to content

Commit

Permalink
chore: remove any trace of lerna (#714)
Browse files Browse the repository at this point in the history
* chore: remove any trace of lerna

* chore: remove lerna from readme

* chore: remove lerna debug log from gitignore
  • Loading branch information
daine authored Dec 18, 2024
1 parent 83c01c0 commit 2099bcd
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ You can find the full documentation for GC Design System Components on [https://
- Run `npm install` to install all Node.js dependencies.
- Run `npm run build` to compile all three packages (web components, react and angular).

You can test the Angular and React packages locally as this repository is setup using [lerna](https://lerna.js.org/) which uses [`npm workspaces`](https://docs.npmjs.com/cli/v10/using-npm/workspaces) under the hood. Npm workspaces automatically handles the linking of dependent packages on `npm install` so there is no need to manually use `npm link`.
You can test the Angular and React packages locally as this repository is setup using [`npm workspaces`](https://docs.npmjs.com/cli/v10/using-npm/workspaces). Npm workspaces automatically handles the linking of dependent packages on `npm install` so there is no need to manually use `npm link`.

<br/>
<br/>
Expand Down Expand Up @@ -83,7 +83,7 @@ Toute la documentation sur les composants de Système de design GC est accessibl
- Exécutez ensuite `npm install` pour installer toutes les dépendances Node.js.
- Finalement, exécutez `npm run build` pour compiler les trois paquets (composants Web, React et Angular).

Vous pouvez tester localement les paquets Angular et React puisque ce référentiel est configuré à l’aide de [lerna](https://lerna.js.org/), qui utilise [`npm workspaces`](https://docs.npmjs.com/cli/v10/using-npm/workspaces) à la base. Npm workspaces gère automatiquement la liaison de paquets dépendants à l’exécution de `npm install`, donc nul besoin d’exécuter manuellement `npm link`.
Vous pouvez tester localement les paquets Angular et React puisque ce référentiel est configuré à l’aide de [`npm workspaces`](https://docs.npmjs.com/cli/v10/using-npm/workspaces). Npm workspaces gère automatiquement la liaison de paquets dépendants à l’exécution de `npm install`, donc nul besoin d’exécuter manuellement `npm link`.

<br/>
<br/>
Expand Down
1 change: 0 additions & 1 deletion packages/vue/tests/app/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ npm-debug.log*
yarn-debug.log*
yarn-error.log*
pnpm-debug.log*
lerna-debug.log*

node_modules
dist
Expand Down
4 changes: 2 additions & 2 deletions utils/scripts/upload_to_cdn.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ PACKAGE_NAME=$1
## Path to the release manifest which has the version numbers
RELEASE_PLEASE_MANIFEST=".release-please-manifest.json"

# Check if lerna.json exists
# Check if the release please manifest file exists
if [ ! -f "$RELEASE_PLEASE_MANIFEST" ]; then
echo ".release-please-manifest.json not found!"
exit 1
fi

echo "Current working directory: $(pwd)"

## Read and process lerna.json using jq to get the package version
## Read and process .release-please-manifest.json using jq to get the package version
PACKAGE_VERSION=$(jq -r '."packages/web"' $RELEASE_PLEASE_MANIFEST)

echo "PACKAGE_VERSION: $PACKAGE_VERSION"
Expand Down

0 comments on commit 2099bcd

Please sign in to comment.