Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add react ssr #587

Merged
merged 16 commits into from
Jul 31, 2024
Merged

ci: add react ssr #587

merged 16 commits into from
Jul 31, 2024

Conversation

daine
Copy link
Collaborator

@daine daine commented Jul 19, 2024

Summary | Résumé

PR to add the react ssr package

Canary release for the React SSR Package

This is an implementation of the Canary Release Plan

Checklist:

Potential impacts:

Impact Notes
Publish Packages runs multiple times Tested this and NPM will not let it happen -- it will error out
🙅‍♀️ <packagename> already published.
Release please not detecting canary version bump Will need to be on the lookout for this, it will be too hard to test multiple releases so we will have to accommodate and fix it when it happens

@daine daine marked this pull request as ready for review July 24, 2024 17:51
@daine
Copy link
Collaborator Author

daine commented Jul 24, 2024

Tested the CI run here for publishing:
https://github.com/daine/gcds-components/actions/runs/10071411555/job/27841892005
Screenshot 2024-07-24 at 10 52 35 AM

I commented out everything else but the react-ssr package. It was successful, so I then tested that package on the NextJS PR and it works on dev and builds.

@daine daine requested review from ethanWallace and melaniebmn July 24, 2024 17:53
Copy link
Collaborator

@ethanWallace ethanWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing

"lint": "eslint ."
},
"dependencies": {
"@cdssnc/gcds-components": "^0.22.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you up the web components package dependency version to the latest version? 0.22.2

ethanWallace
ethanWallace previously approved these changes Jul 29, 2024
Copy link
Collaborator

@ethanWallace ethanWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

melaniebmn
melaniebmn previously approved these changes Jul 29, 2024
Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - ship it! Wohoooo

@daine daine dismissed stale reviews from melaniebmn and ethanWallace via 071a0f8 July 30, 2024 20:44
@daine daine requested review from melaniebmn and ethanWallace July 31, 2024 19:50
Copy link
Collaborator

@ethanWallace ethanWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants