-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add react ssr #587
ci: add react ssr #587
Conversation
Update README.md
Tested the CI run here for publishing: I commented out everything else but the react-ssr package. It was successful, so I then tested that package on the NextJS PR and it works on dev and builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small thing
packages/react-ssr/package.json
Outdated
"lint": "eslint ." | ||
}, | ||
"dependencies": { | ||
"@cdssnc/gcds-components": "^0.22.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you up the web components package dependency version to the latest version? 0.22.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - ship it! Wohoooo
build: Remove lerna from build script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary | Résumé
PR to add the react ssr package
Canary release for the React SSR Package
This is an implementation of the Canary Release Plan
Checklist:
gcds-components-react-ssr/package.json
has the correct canary version format0.22.2-canary.0
as of July 24, 2024npm publish
has been tested4.11.0
since we have a patch dependency on it, which we will have to update once we upgrade.Potential impacts:
🙅♀️ <packagename> already published.