Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate grid column component into its own directory #733

Merged
merged 11 commits into from
Jan 20, 2025

Conversation

melaniebmn
Copy link
Collaborator

@melaniebmn melaniebmn commented Jan 16, 2025

Summary | Résumé

Move the grid column component to its own directory.

This PR separates the grid-col component into its own dedicated directory. The goal is to provide better organization and enable the creation of individual README for both the grid and the grid-col components.

How to test

The new grid README can be viewed here and the new grid-col README can be viewed here.

Both components work the same as before. They can be tested by using this example code:

<gcds-grid columns-desktop="1fr 1fr 1fr 1fr" columns-tablet="1fr 1fr" columns="1fr">
    <p>Example content</p>
    <p>Example content</p>
    <p>Example content</p>
    <p>Example content</p>
</gcds-grid>

<gcds-grid>
    <gcds-grid-col tablet="3" desktop="3">Example content for grid column.</gcds-grid-col>
    <gcds-grid-col tablet="3" desktop="3">Example content for grid column.</gcds-grid-col>
    <gcds-grid-col tablet="3" desktop="3">Example content for grid column.</gcds-grid-col>
    <gcds-grid-col tablet="3" desktop="3">Example content for grid column.</gcds-grid-col>
</gcds-grid>

Copy link
Collaborator

@ethanWallace ethanWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melaniebmn melaniebmn changed the title refactor: separate grid column component into its own directory chore: separate grid column component into its own directory Jan 17, 2025
Copy link
Collaborator

@daine daine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally by using gcds-grid-col within a gcds-grid as usual and it works the same

@melaniebmn melaniebmn merged commit dadbda3 into main Jan 20, 2025
3 checks passed
@melaniebmn melaniebmn deleted the chore/create-directory-grid-col branch January 20, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants