Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update grid spacing + test names #737

Merged
merged 3 commits into from
Jan 22, 2025
Merged

chore: update grid spacing + test names #737

merged 3 commits into from
Jan 22, 2025

Conversation

melaniebmn
Copy link
Collaborator

@melaniebmn melaniebmn commented Jan 20, 2025

Summary | Résumé

I added the PR suggestions from @daine, which are mentioned in this PR.

I also added i18n support for gap error messages.

@melaniebmn melaniebmn requested a review from daine January 20, 2025 23:12
@melaniebmn melaniebmn changed the title Update grid chore: update grid spacing + test names Jan 21, 2025
Copy link
Collaborator

@daine daine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@ethanWallace ethanWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daine daine merged commit 2fb1633 into main Jan 22, 2025
3 checks passed
@daine daine deleted the update-grid branch January 22, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants