Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MANIFEST] removing personlisation limit #2813

Merged
merged 1 commit into from
Jul 30, 2024
Merged

[MANIFEST] removing personlisation limit #2813

merged 1 commit into from
Jul 30, 2024

Conversation

jzbahrai
Copy link
Collaborator

What happens when your PR merges?

reverting this: #2794

➜  notification-manifests git:(reverts) ✗ make diff-staging
Archive:  .previous.env.zip
  inflating: .env
Archive:  .env.zip
  inflating: .env
1d0
< PERSONALISATION_SIZE_LIMIT=144618
117c116
< AWS_XRAY_DAEMON_ADDRESS=
\ No newline at end of file
---
> AWS_XRAY_DAEMON_ADDRESS=
make: *** [diff-staging] Error 1
make diff-production
Archive:  .previous.env.zip
  inflating: .env
Archive:  .env.zip
  inflating: .env
1d0
< PERSONALISATION_SIZE_LIMIT=144618
116c115
< AWS_XRAY_DAEMON_ADDRESS=
\ No newline at end of file
---
> AWS_XRAY_DAEMON_ADDRESS=
make: *** [diff-production] Error 1

@jzbahrai jzbahrai requested a review from jimleroyer as a code owner July 30, 2024 20:15
Copy link

ingress	nginx    	2       	2024-02-12 19:08:42.93215444 +0000 UTC	deployed	nginx-ingress-1.1.2	3.4.2      

xray-daemon	xray     	1       	2024-07-29 19:45:48.684608347 +0000 UTC	deployed	aws-xray-4.0.8	3.3.12     

Comparing release=karpenter-crd, chart=/tmp/helmfile2552871503/karpenter/staging/karpenter-crd/karpenter-crd/0.36.1/karpenter-crd
Comparing release=karpenter, chart=/tmp/helmfile2552871503/karpenter/staging/karpenter/karpenter/0.36.1/karpenter
Comparing release=karpenter-nodepool, chart=charts/karpenter-nodepool
Comparing release=priority-classes, chart=deliveryhero/priority-class
Comparing release=secrets-store-csi-driver, chart=secrets-store-csi-driver/secrets-store-csi-driver
Comparing release=aws-secrets-provider, chart=aws-secrets-manager/secrets-store-csi-driver-provider-aws
Comparing release=kube-state-metrics, chart=prometheus-community/kube-state-metrics
Comparing release=blazer, chart=stakater/application
Comparing release=ingress, chart=charts/nginx-ingress
Comparing release=xray-daemon, chart=okgolove/aws-xray

Copy link
Member

@jimleroyer jimleroyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jzbahrai jzbahrai merged commit 0e3c50f into main Jul 30, 2024
4 checks passed
@jzbahrai jzbahrai deleted the reverts branch July 30, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants