Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MANIFEST] added env variable #2925

Merged
merged 1 commit into from
Sep 10, 2024
Merged

[MANIFEST] added env variable #2925

merged 1 commit into from
Sep 10, 2024

Conversation

jzbahrai
Copy link
Collaborator

What happens when your PR merges?

ERROR:


Invalid workflow file: .github/workflows/merge_to_main_staging.yaml#L135The workflow is not valid. .github/workflows/merge_to_main_staging.yaml (Line: 135, Col: 11): Input environment is required, but not provided while calling.
--


[Invalid workflow file: .github/workflows/merge_to_main_staging.yaml#L135](https://github.com/cds-snc/notification-manifests/actions/runs/10774286400/workflow)
The workflow is not valid. .github/workflows/merge_to_main_staging.yaml (Line: 135, Col: 11): Input environment is required, but not provided while calling.

Added the env variable to try and fix it.

What are you changing?

  • Releasing a new version of Notify
  • Changing kubernetes configuration

Provide some background on the changes

Give details ex. Security patching, content update, more API pods etc

If you are releasing a new version of Notify, what components are you updating

  • API
  • Admin
  • Documentation
  • Document download API

Checklist if releasing new version:

Checklist if making changes to Kubernetes:

  • I know how to get kubectl credentials in case it catches on fire

After merging this PR

  • I have verified that the tests / deployment actions succeeded
  • I have verified that any affected pods were restarted successfully
  • I have verified that I can still log into Notify production
  • I have verified that the smoke tests still pass on production
  • I have communicated the release in the #notify Slack channel.

Copy link

xray-daemon	xray     	1       	2024-07-29 19:45:48.684608347 +0000 UTC	deployed	aws-xray-4.0.8	3.3.12     

ingress	nginx    	2       	2024-02-12 19:08:42.93215444 +0000 UTC	deployed	nginx-ingress-1.1.2	3.4.2      

Comparing release=karpenter-crd, chart=/tmp/helmfile3518056789/karpenter/staging/karpenter-crd/karpenter-crd/0.36.1/karpenter-crd
Comparing release=karpenter, chart=/tmp/helmfile3518056789/karpenter/staging/karpenter/karpenter/0.36.1/karpenter
Comparing release=karpenter-nodepool, chart=charts/karpenter-nodepool
Comparing release=priority-classes, chart=deliveryhero/priority-class
Comparing release=secrets-store-csi-driver, chart=secrets-store-csi-driver/secrets-store-csi-driver
Comparing release=aws-secrets-provider, chart=aws-secrets-manager/secrets-store-csi-driver-provider-aws
Comparing release=kube-state-metrics, chart=prometheus-community/kube-state-metrics
Comparing release=blazer, chart=stakater/application
Comparing release=ingress, chart=charts/nginx-ingress
Comparing release=xray-daemon, chart=okgolove/aws-xray

@jzbahrai jzbahrai merged commit a9c92a7 into main Sep 10, 2024
5 checks passed
@jzbahrai jzbahrai deleted the task/fix-env branch September 10, 2024 15:58
jzbahrai added a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants