Automatic VPN Config Generation #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingress nginx 2 2024-02-12 19:08:42.93215444 +0000 UTC deployed nginx-ingress-1.1.2 3.4.2
xray-daemon xray 1 2024-07-29 19:45:48.684608347 +0000 UTC deployed aws-xray-4.0.8 3.3.12
Comparing release=karpenter-crd, chart=/tmp/helmfile2889160117/karpenter/staging/karpenter-crd/karpenter-crd/0.36.1/karpenter-crd
Comparing release=karpenter, chart=/tmp/helmfile2889160117/karpenter/staging/karpenter/karpenter/0.36.1/karpenter
Comparing release=karpenter-nodepool, chart=charts/karpenter-nodepool
Comparing release=priority-classes, chart=deliveryhero/priority-class
Comparing release=secrets-store-csi-driver, chart=secrets-store-csi-driver/secrets-store-csi-driver
Comparing release=aws-secrets-provider, chart=aws-secrets-manager/secrets-store-csi-driver-provider-aws
Comparing release=kube-state-metrics, chart=prometheus-community/kube-state-metrics
Comparing release=blazer, chart=stakater/application
Comparing release=ingress, chart=charts/nginx-ingress
Comparing release=xray-daemon, chart=okgolove/aws-xray |
jimleroyer
reviewed
Sep 11, 2024
| </cert>" >> /var/tmp/production.ovpn | ||
| echo "<key> | ||
| $KEY | ||
| </key>" >> /var/tmp/production.ovpn |
There was a problem hiding this comment.
That seems to warrant a dedicated script for it, as this would reduce the mental load of reading this file, minimize code duplication and ease up maintenance altogether.
jimleroyer
reviewed
Sep 11, 2024
| aws ec2 export-client-vpn-client-configuration --client-vpn-endpoint-id $ENDPOINT_ID --output text > /var/tmp/production.ovpn | ||
| echo "<cert> | ||
| $CERT | ||
| </cert>" >> /var/tmp/production.ovpn |
There was a problem hiding this comment.
We might want to be extra safe and silence potential errors 2>/dev/null in case something bad happens (unlikely things such as no space left on device, folder not existing, etc).
jzbahrai
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happens when your PR merges?
This will automatically generate the VPN Config for staging and production so that we don't have to manage 1Password secrets for github action VPN config manually.
What are you changing?
Provide some background on the changes
We are changing the VPN config in notification-terraform, and unless we apply these changes, we would have to manually modify the VPN config files.
If you are releasing a new version of Notify, what components are you updating
Checklist if making changes to Kubernetes:
After merging this PR