Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing using controller's value as initial value #218

Merged
merged 10 commits into from
Feb 12, 2024

Conversation

muccy-timeware
Copy link
Contributor

If you initialize the field with an empty controller and you update its value too soon, you end up having a filled field that failed required validation.

This fix uses controller.value (if any) during initialization pretty much like TextFormField does.

Copy link
Owner

@cedvdb cedvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the format back on the line that changed ? I think you have a bigger line length than 80.

If possible add a test too so this does not break in the future

cedvdb

This comment was marked as duplicate.

@muccy-timeware
Copy link
Contributor Author

Done.
I hope the test is good because I never wrote a UI test before, honestly

@cedvdb
Copy link
Owner

cedvdb commented Feb 12, 2024

Perfect thank you.

Released in v9.0.5

@cedvdb cedvdb merged commit 2e187c8 into cedvdb:main Feb 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants