Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hungarian localization messages #226

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

emri99
Copy link
Contributor

@emri99 emri99 commented Mar 13, 2024

Content

  • New supported language : Hungarian

Notice

Changes on existing generated files seems useless & only related to formatter.

I've used flutter 3.19.3 and command flutter gen-l10n.

  • If you want me to fix generated files, can you tell me how you generate them ?
  • I can remove the last commit if you prefer to build them by yourself ;)

@cedvdb
Copy link
Owner

cedvdb commented Mar 13, 2024

Thanks, You can just run dart fix --apply to fix the generated files

@emri99
Copy link
Contributor Author

emri99 commented Mar 13, 2024

Changes remains about line length like here, do I need to do anything else ?

I was thinking about push force to cancel the modifications I've made so they'll never appear in history, is that ok for you ?

@cedvdb
Copy link
Owner

cedvdb commented Mar 13, 2024

I don't know what's up with those line length, it seems to change in every other PR and I let it pass. So honnestly just push it with dart fix --apply and with the line length changes.

@emri99 emri99 force-pushed the feat-add-hu-locale branch from c1f4fe5 to 70e2cad Compare March 13, 2024 12:02
@emri99
Copy link
Contributor Author

emri99 commented Mar 14, 2024

Generated files updated & push-forced. Let me know if anything else should be changed ;)

Sorry (misclick on Comment & Close !)

@emri99 emri99 closed this Mar 14, 2024
@emri99 emri99 reopened this Mar 14, 2024
@cedvdb cedvdb merged commit 3e584d5 into cedvdb:main Mar 14, 2024
2 checks passed
@emri99
Copy link
Contributor Author

emri99 commented Mar 26, 2024

Sorry to bother you, do you have planned to release a version including this update ?

Thanks again for your hard work

@cedvdb
Copy link
Owner

cedvdb commented Mar 26, 2024

It's going to be in the upcoming days, I would like to ship other fixes as well

@emri99
Copy link
Contributor Author

emri99 commented Mar 26, 2024

Perfect ! Thanks for the info ;)

@cedvdb
Copy link
Owner

cedvdb commented Mar 27, 2024

Not sure why you did not add all hu message but I'm adding the remaining ones via google translate since i'm doing it for each missing translation:

  "selectACountrySemanticLabel": "Válasszon országot, jelenlegi választás: {countryName} {dialCode}",
  "@selectACountrySemanticLabel": {
    "description": "semantic description of the country button",
    "placeholders": {
      "countryName": {
        "type": "String"
      },
      "dialCode": {
        "type": "String"
      }
    }
  },
  "phoneNumber": "Telefonszám",
  "currentValueSemanticLabel": "Jelenlegi érték: {currentValue}",
  "@currentValueSemanticLabel": {
    "description": "semantic description of the phone input. The label or hint will be dynamically added",
    "placeholders": {
      "currentValue": {
        "type": "String"
      }
    }
  }

@emri99
Copy link
Contributor Author

emri99 commented Mar 27, 2024

Hmm... Neither do I ! Sorry for that !

@cedvdb
Copy link
Owner

cedvdb commented Mar 28, 2024

No problem, I've added language selection to the demo if you want to check the hungarian language https://cedvdb.github.io/phone_form_field/

@emri99
Copy link
Contributor Author

emri99 commented Mar 29, 2024

Check done ! No problem found ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants