fix: #270 allow deleting area codes #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting of the entered number is now skipped if the text input is within an area code, such as (416 and the closing parentheses is missing.
|
Thanks, that's a big one (issue). I wonder if it should be prevented for any delete. I'm thinking out loud here. It doesn't seem necessary since this issue happens only with parenthesis but maybe it would be simpler ? Could you also add the patched version to the changelog and pubspec ? |
Done. I have bumped the version to 10.0.2. I couldn't see 10.0.1 in the repo though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting of the entered number is now skipped if the text input is within an area code, such as (416 and the closing parentheses is missing.
Closes #270