-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GDB pretty-printers for range and grid types #207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
8f042b3
to
3d62e7b
Compare
3d62e7b
to
5885f39
Compare
Check-perf-impact results: (5a19ced85f862a00d0114dd241122462) ❓ No new benchmark data submitted. ❓ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. (I only looked through the code and the test, didn't try it locally)
After sourcing .gdbinit, GDB will pretty-print - phantom types (tast_id, node_id, ...) - range, subrange, chunk, nd_range - box, region - region_map - write_command_state - gch::small_vector
a6c7260
to
56b3cf8
Compare
Check-perf-impact results: (b003273516680ef3e6ca0110b3678f5e) ❓ No new benchmark data submitted. ❓ |
Since this only adds debugging infrastructure and does not touch the runtime (apart from one renamed variable), I'm going to go ahead and merge this with the current state of reviews. |
For the following values:
The pretty-print appears as follows:
The printers are auto-loaded through the root
.gdbinit
file together with pretty printers forgch::small_vector
, but only if the work tree is configured as a safe auto-load path in GDB. This is can be configured locally as follows:TODO
subrange
notation, also use that inprint_utils