Generate single await-push command per buffer for all local chunks #324
+432
−394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings await-pushes in line with pushes, where we already compute the union of all regions required by remote chunks executed on the same node.
|
Check-perf-impact results: (241536968c1afd627708e72c171c89f6) 🚀 Significant speedup (<0.80x) in some microbenchmark results: benchmark intrusive graph dependency handling with N nodes - 100 / creating nodes Relative execution time per category: (mean of relative medians)
|
Pull Request Test Coverage Report for Build 12435190957Details
💛 - Coveralls |
GagaLP
approved these changes
Jan 7, 2025
| for(const auto& [box, wcs] : local_sources) { | ||
| // Note that we initialize all buffers as fresh, so this doesn't trigger for uninitialized reads | ||
| if(!box.empty() && !wcs.is_fresh()) { missing_part_boxes.add(box); } | ||
| if(!box.empty() && !wcs.is_fresh()) { missing_parts_boxes.push_back(box); } | ||
| } | ||
|
|
||
| // There is data we don't yet have locally. Generate an await push command for it. |
There was a problem hiding this comment.
For me this comment now seems a bit out of place since we don't generate the await push command in this if.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings await-pushes in line with pushes, where we already compute the union of all regions required by remote chunks executed on the same node.