Improve error reporting during indexing #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous behavior was to basically suppress all error diagnostics generated by Clang during indexing, and only rely on the return value of `ClangTool::run` to decide whether a file was parsed correctly or not. For irrecoverable errors such as missing files this doesn't give one much to work with. The new behavior is to parse all diagnostics and check for missing files, and if there are some, print those immediately. For other errors that may be encountered, we now keep count of how many there are, and offer the option to print them using --verbose output.
|
Maybe provide a hint to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behavior was to basically suppress all error diagnostics generated by Clang during indexing, and only rely on the return value of
ClangTool::runto decide whether a file was parsed correctly or not.For irrecoverable errors such as missing files this doesn't give one much to work with. The new behavior is to parse all diagnostics and check for missing files, and if there are some, print those immediately.
For other errors that may be encountered, we now keep count of how many there are, and offer the option to print them using --verbose output.