-
-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added initial draft github action workflow #1299
Conversation
Error: Container operations are only supported on Linux runners -- so integration tests with docker need Linux only |
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: [ubuntu-20.04, macos-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macos & windows can run unit tests and container based integration can run on llinux only, so separate jobs should be created
related celery/py-amqp#358 |
I am a little bit sick. I saw PR of @matusvalo in pyamqp, which I can take as a suggested way. @matusvalo you can push on CI branch as well if got time. |
@auvipy I was checking your branch but your approach is totally different from my PR so I decided to create separate new PR of it. (there is no benefit integrating it in your PR since I would overwrite whole file). Though, your PR contains some great stuff (like coverage, cache etc). Maybe after accepting basic PR of CI you could create PR for adding them to it? (I would like to have simple running CI ASAP, since we introduced some issues/failing unit tests due not having CI running) |
OK |
I think yes. But we can use some parts of this PR which are missing in current CI (cache, covetage etc) |
i will improve this PR |
initial experiments