Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault with imports across multiple directories #1304

Merged
merged 6 commits into from
Nov 24, 2024

Conversation

hsorby
Copy link
Contributor

@hsorby hsorby commented Nov 20, 2024

It appears the importer is not matching units correctly when importing units across multiple directories.

Fixes #1302.

@hsorby hsorby added the Bug label Nov 20, 2024
@hsorby hsorby requested review from agarny and nickerso November 21, 2024 19:34
Copy link
Contributor

@agarny agarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine pending one minor change.

tests/test_utils.cpp Outdated Show resolved Hide resolved
@agarny agarny self-requested a review November 21, 2024 22:02
@agarny agarny merged commit b3fb67a into cellml:main Nov 24, 2024
25 checks passed
@hsorby hsorby deleted the importer-segfault branch November 25, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SegFault during model flattening
3 participants