PR: Add tests to validate results from the HELP3O extension against a genuine test case #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test that the HELP3O extension run and create an output file as expected.
Run HELP for a single cell using the RCA test case and assert that the result are as expected.
jnsebgosselin
added
tag: HELP modifs
|
Hello @jnsebgosselin! Thanks for updating the PR.
Comment last updated on November 27, 2018 at 06:13 Hours UTC |
jnsebgosselin
changed the title
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After my failed attempt at fixing Issue #24 in PR #45, I realized how important it was that I implemented tests to validate the results from the HELP3O extension against a genuine test case.
This PR does that by adding tests that runs the HELP3O extension against a test case that was originally created in 1997 and distributed alongside the official FORTRAN source code of HELP version 3.07.
The files from this original test case are also added to this repo in this PR.