Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support node: prefix for built-in modules [sc-22633] #1009

Conversation

sorccu
Copy link
Collaborator

@sorccu sorccu commented Jan 19, 2025

This PR makes both import 'node:path' and import 'path' equivalent.

Also fixes a typo in the supported dependency list: 'readline ' had a trailing space.

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Resolves #[issue-number]

New Dependency Submission

Base automatically changed from simokinnunen/sc-22644/support-tsconfig-paths-and-package-relative to main January 20, 2025 06:14
@sorccu sorccu force-pushed the simokinnunen/sc-22633/support-node-prefix-for-built-in-node-dependencies branch from f2b5c4d to 9bbfcad Compare January 20, 2025 06:19
@sorccu sorccu merged commit 33f3c08 into main Jan 20, 2025
3 checks passed
@sorccu sorccu deleted the simokinnunen/sc-22633/support-node-prefix-for-built-in-node-dependencies branch January 20, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant