Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Test/openmm 8.1.0rc1 #1243

Closed
wants to merge 12 commits into from
Closed

[DNM] Test/openmm 8.1.0rc1 #1243

wants to merge 12 commits into from

Conversation

mikemhenry
Copy link
Contributor

No description provided.

@mikemhenry
Copy link
Contributor Author

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #1243 (8336ca0) into main (7eaa162) will decrease coverage by 8.41%.
The diff coverage is n/a.

Additional details and impacted files

@ijpulidos
Copy link
Contributor

Thanks! No idea why the changes in #1242 didn't work, I'll be closing that.

With regards the GPU, I don't think the 8.1 rc is getting picked up by it, as per https://github.com/choderalab/perses/actions/runs/6894390986/job/18756206563#step:7:287

@mikemhenry
Copy link
Contributor Author

Haha that is my bad, I didn't even update the yaml file for the gpu jobs 🤦

@mikemhenry
Copy link
Contributor Author

@mikemhenry
Copy link
Contributor Author

(ignore the CPU tests right now, they passed already so its okay I made a mistake)

@mikemhenry
Copy link
Contributor Author

@ijpulidos okay looks like 2 errors on the GPU tests:
https://github.com/choderalab/perses/actions/runs/6896894039/job/18764058862

One error looks like an API bug, the other though might be real:

FAILED perses/tests/test_repex.py::test_RESTCapableHybridTopologyFactory_repex_charge_mutation - pymbar.utils.ParameterError: Warning: Should have \sum_n W_nk = 1. Actual column sum for state 0 was 275.917719. 38 other columns have similar problems. 
This generally indicates the free energies are not converged.

image
The tests work on main quite reliably, so we should investigate this IMHO, the first thing I will do is try and re-run the test to see if it happens again

@mikemhenry
Copy link
Contributor Author

re-running things here: https://github.com/choderalab/perses/actions/runs/6896894039

@ijpulidos
Copy link
Contributor

@mikemhenry it's actually something we have encountered before choderalab/pymbar#419 I'm still not sure why is this happening, but I think it's only showing with pymbar4

@mikemhenry
Copy link
Contributor Author

We really need to track down that pymbar bug

@mikemhenry mikemhenry closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants