-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue docstring harmonic #541
Issue docstring harmonic #541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Reminds me we need to do a full switch over to u_kn vs u_kln in examples . . . .
2f5a09f
to
495792a
Compare
Failure due to pylint issues that are unrelated. |
Why remove |
Thanks for the docstring fixes! |
I found this to be an issue when I tried to add some words to my personal VS Code settings and they were added to this file. At that point, git wanted to add my settings to your repository. I thought it would be better to delete a random person's vs code settings with their python path so that I could have my own personal settings, and other people would also avoid adding their personal settings to your repository. |
AH! Wow okay -- so I didn't realize that we were tracking Instead of removing it from the git ignore, can you
That is how it should have been setup from the start -- sorry for the confusion and I am really grateful for your contribution! |
@mikemhenry This PR both deletes the vscode files you were carrying in the repository and adds vscode files to gitignore to prevent this issue in the future. |
Remove .vscode settings and have the docstring for the HarmonicOscillator be consistent with the code.