Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrangeable columns #167

Merged
merged 20 commits into from
Apr 6, 2024
Merged

Rearrangeable columns #167

merged 20 commits into from
Apr 6, 2024

Conversation

chucker
Copy link
Owner

@chucker chucker commented Oct 30, 2023

Implements #154

Tried this in SwiftUI, but SwiftUI drag & drop on macOS is apparently quite limited. So, NSCollectionView instead.

  • Disable wrapping on collection view items
  • Implement drag & drop
  • Pass window columns
  • Need to make the previous menu item active again after exiting sheet
  • Need to update menu items for existing column as well. For example, if the window previously had just one column, and one is added, we need to add Rearrange… to it.
    - [ ] Maybe: pass each column's aspect ratio as well?
  • finish layout of view items
  • Remove (obsolete) SwiftUI code. Leave for now so we can prototype the items.
  • Apply change
  • dragging is partially broken: for example, dragging from 0 to 1 doesn't seem to work

@chucker chucker marked this pull request as ready for review April 6, 2024 17:50
Sören Kuklau added 20 commits April 6, 2024 19:50
see also yonaskolb/XcodeGen#1411

The issue here was that the `MastonautTests` project implicitly had build types set to `all` instead of `test`, and while that works fine for building and testing, it does not for Previews.
@chucker chucker force-pushed the features/rearrange-columns branch from a37c048 to 1f31234 Compare April 6, 2024 17:50
@chucker chucker merged commit e602275 into main Apr 6, 2024
@chucker chucker deleted the features/rearrange-columns branch April 6, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant