tetra: Set default for retries to 1 #3335
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The grpc update to v1.70.0 and especially [1] requires retries to be > 1 in order to have a valid retry policy. As we already do +1 later, let's set the default to 1. [1] grpc/grpc-go#7905 Suggested-by: Anastasios Papagiannis <[email protected]> Signed-off-by: Jiri Olsa <[email protected]>
olsajiri
added
the
release-note/minor
I believe that we still need that as in e2e tests we just call functions from tetra and not the binary itself. I will check that to be sure and revert that into f needed in a separate PR. |
olsajiri
changed the title
tpapagian
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grpc update to v1.70.0 and especially [1] requires retries to be > 1 in order to have a valid retry policy.
As we already do +1 later, let's set the default to 1.
[1] grpc/grpc-go#7905
Suggested-by: Anastasios Papagiannis [email protected]
Signed-off-by: Jiri Olsa [email protected]