Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Part3 #1594

Closed
wants to merge 4 commits into from
Closed

Translate Part3 #1594

wants to merge 4 commits into from

Conversation

aceArt-GmbH
Copy link
Contributor

Description

Some keys are not yet loaded while already shown. This throws Client suspended while rendering, but no fallback UI was specified.. useSuspense suppresses this, not sure if this is the correct solution though

Builds on #1591

Mixes #681 and https://github.com/REDLINK/cinny/blob/dev/public/locales/de/translation.json and some new translations

cc #164

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@aceArt-GmbH aceArt-GmbH changed the title Translate3 Translate Part3 Dec 18, 2023
@aceArt-GmbH aceArt-GmbH mentioned this pull request Dec 18, 2023
9 tasks
@aceArt-GmbH aceArt-GmbH force-pushed the translate3 branch 2 times, most recently from e89a31a to 73ce208 Compare December 20, 2023 10:19
Copy link

github-actions bot commented May 3, 2024

Preview: https://1594--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant