Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authenticated media support #1930

Merged

Conversation

ShadowRZ
Copy link
Contributor

@ShadowRZ ShadowRZ commented Sep 6, 2024

Description

Implments authenticated media support, which allows Cinny to be used on servers that have frozen unauth media like matrix.org

Fixes #1818

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

github-actions bot commented Sep 6, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ShadowRZ
Copy link
Contributor Author

ShadowRZ commented Sep 6, 2024

I have read the CLA Document and I hereby sign the CLA

ajbura added a commit to cinnyapp/cla that referenced this pull request Sep 6, 2024
@ShadowRZ ShadowRZ marked this pull request as ready for review September 6, 2024 16:28
Copy link

github-actions bot commented Sep 7, 2024

Preview: https://1930--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@ShadowRZ
Copy link
Contributor Author

ShadowRZ commented Sep 7, 2024

Checklist:

  • Login
  • Open F12 Development tools
  • Check for /_matrix/media requests, there should only be /_matrix/media/v3/config and /_matrix/media/v3/preview_url requests (As matrix-js-sdk seems not migrated that.)

@starg2
Copy link

starg2 commented Sep 7, 2024

Excuse me, but why are your git commits "unverified"? Did you forget to upload your GPG key?

Copy link
Contributor Author

@ShadowRZ ShadowRZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse me, but why are your git commits "unverified"? Did you forget to upload your GPG key?

I didn't forget to upload my GnuPG key, unfortunately my GnuPG key on smartcard setup seems to have problems and GnuPG can't sign a proper signature that can be verified by itself.

I'll have it fixed, thank you for notify me this.

@ajbura
Copy link
Member

ajbura commented Sep 7, 2024

@ShadowRZ can you please add sw.js file redirect in /netlify.toml so it can be tested on https://1930--pr-cinny.netlify.app/

Otherwise the generic SPA rewrite to index.html would take effect, breaking Service Worker.
@ShadowRZ
Copy link
Contributor Author

ShadowRZ commented Sep 7, 2024

Done in 723c76a

Also checked, the sw.js can be loaded.

Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you for contributing.

src/index.tsx Outdated Show resolved Hide resolved
src/sw.ts Outdated Show resolved Hide resolved
Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on it!

@ajbura ajbura merged commit c6a8fb1 into cinnyapp:dev Sep 7, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for MSC3916: Authenticated Media
3 participants