-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add authenticated media support #1930
Add authenticated media support #1930
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Preview: https://1930--pr-cinny.netlify.app |
Checklist:
|
Excuse me, but why are your git commits "unverified"? Did you forget to upload your GPG key? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excuse me, but why are your git commits "unverified"? Did you forget to upload your GPG key?
I didn't forget to upload my GnuPG key, unfortunately my GnuPG key on smartcard setup seems to have problems and GnuPG can't sign a proper signature that can be verified by itself.
I'll have it fixed, thank you for notify me this.
@ShadowRZ can you please add |
Otherwise the generic SPA rewrite to index.html would take effect, breaking Service Worker.
Done in 723c76a Also checked, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thank you for contributing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on it!
Description
Implments authenticated media support, which allows Cinny to be used on servers that have frozen unauth media like matrix.org
Fixes #1818
Type of change
Checklist: