Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sort of Side Drawer Advance Filters (CRASM-967) #740

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

Fix sort of Side Drawer Advance Filters (CRASM-967) #740

wants to merge 11 commits into from

Conversation

hawkishpolicy
Copy link
Collaborator

@hawkishpolicy hawkishpolicy commented Dec 12, 2024 •
edited
Loading

Applies a more user friendly and consistent display, plus increased functionality, to the checkbox controlled filters in the Advanced Filters section of the Side Drawer.

🗣 Description

  • Applied ascending sort to the following Advanced Filters:
    • Root Domain(s)
    • Ports
    • CVE
    • Severity
  • Added grouping and sorting logic similar to that of VulnerabilityBarChart to Severity Filters:
    • Null, undefined, empty string, and N/A values are placed into the "N/A" category.
    • Special characters, numbers, and Other are placed into the "Other" category.
    • All categories are now case insensitive.
  • Fixed issue with npm run syncdb:
    • searchSync was nested inside of syncdb -- -d populate.
    • This was preventing local db changes from syncing.
    • Issue is resolved.

💭 Motivation and context

🧪 Testing

  • Tested locally.

📷 Screenshots (if appropriate)

Screenshot 2024-12-12 at 10 22 11 AM Screenshot 2024-12-12 at 10 22 32 AM Screenshot 2024-12-12 at 10 22 44 AM Screenshot 2024-12-12 at 10 22 55 AM

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@hawkishpolicy
Edited DrawerInterior.tsx to fix filter sort
186bbdc 
- Added sort to portFacet.
- Added sort to cveFacet.
- Severity levels are now sorted in order of Low, Medium, High, Critical.
@hawkishpolicy
Edited severityFacet logic and syncdb script
938777f 
- npm run syncdb was not syncing domains on run due to it being nested inside syncdb -- -d populate.
-- Thus changes to local db were not being reflected in the search index.
- Edited severityFacet logic to only show severity filters if there are severity filters to show.
- Added a sort to display severity filters in the following order: N/A, Low, Medium, High, Critical, Other.
@hawkishpolicy
Edited Severity Facet Filter in DrawerInterior.tsx
48a5907 
- Added data validation logic to group irregular severity values into appropriate categories.
- Null, empty string, N/A, and undefined values are grouped into the "N/A" category.
- Special characters, numbers, and Other are grouped into the "Other" category.
- All categories are case insensitive.
- Edited vulnerability.severity agg in buildRequest.ts to inclues "null" values.
- Increased aggregation size to 50 to include all severity values.
@hawkishpolicy
Cleaned up code
7e9723f 
- Removed console.logs.
- Removed commented out code.
@hawkishpolicy hawkishpolicy self-assigned this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 will be requested when the pull request is marked ready for review aloftus23 is a code owner

@cduhn17 cduhn17 Awaiting requested review from cduhn17 cduhn17 will be requested when the pull request is marked ready for review cduhn17 is a code owner

@Matthew-Grayson Matthew-Grayson Awaiting requested review from Matthew-Grayson Matthew-Grayson will be requested when the pull request is marked ready for review Matthew-Grayson is a code owner

@nickviola nickviola Awaiting requested review from nickviola nickviola will be requested when the pull request is marked ready for review nickviola is a code owner

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 will be requested when the pull request is marked ready for review rapidray12 is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 will be requested when the pull request is marked ready for review schmelz21 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@hawkishpolicy hawkishpolicy

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hawkishpolicy