Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed State Select during account creation (CRASM-892) #746

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Fixed State Select during account creation (CRASM-892) #746

merged 3 commits into from
Jan 22, 2025

Conversation

hawkishpolicy
Copy link
Collaborator

  • New users are prompted to select their State upon initial account creation.
  • Their selection was returning as unauthorized due to some checks in the update users call.
  • This PR addresses that.

🗣 Description

  • Added an additional condition to the update User call to allow for new users to select their State upon account creation.
  • If invitePending is true, a User can update their state regardless of their Region ID.

💭 Motivation and context

🧪 Testing

  • tested locally with new accounts.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@hawkishpolicy
Edited users.ts
4d9ea65 
- Added an additional condition to the update User call to allow for new users to select their State upon account creation.
- If invitePending is true, a User can update their state regardless of their Region ID.
@hawkishpolicy hawkishpolicy added bug This issue or pull request addresses broken functionality frontend labels Dec 20, 2024
@hawkishpolicy hawkishpolicy self-assigned this Dec 20, 2024
@hawkishpolicy
Refined User State Selection Form
af52494 
- Cancel button is diabled if user.invitePending is true.
- Dialog does not close on background click nor escape key press.
- This is to prevent the user from closing the dialog before they have made a selection.
@hawkishpolicy
Merge remote-tracking branch 'origin/develop' into User-State-Selecti…
f0ecf2d 
…on-Not-Saving-CRASM-892
@hawkishpolicy hawkishpolicy marked this pull request as ready for review January 8, 2025 18:40
nickviola
nickviola approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chrtorres
chrtorres approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@chrtorres chrtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21 schmelz21 merged commit 808bcac into develop Jan 22, 2025
17 of 19 checks passed
@schmelz21 schmelz21 deleted the User-State-Selection-Not-Saving-CRASM-892 branch January 22, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrtorres chrtorres chrtorres approved these changes

@schmelz21 schmelz21 schmelz21 approved these changes

@nickviola nickviola nickviola approved these changes

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 is a code owner

@cduhn17 cduhn17 Awaiting requested review from cduhn17 cduhn17 is a code owner

@Matthew-Grayson Matthew-Grayson Awaiting requested review from Matthew-Grayson Matthew-Grayson is a code owner

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

Assignees

@hawkishpolicy hawkishpolicy

Labels
bug This issue or pull request addresses broken functionality frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hawkishpolicy @nickviola @schmelz21 @chrtorres