Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pytest to list of Phony commands #754

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Add Pytest to list of Phony commands #754

merged 1 commit into from
Jan 9, 2025

Conversation

JCantu248
Copy link
Collaborator

🗣 Description

Add pytest to list of phony commands in Makefile.

💭 Motivation and context

This is required to be able to run pytest as a runnable command with make.

🧪 Testing

It was tested by verifying that the pytest cases worked with the make pytest command.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@JCantu248 JCantu248 added test This issue or pull request adds or otherwise modifies test code backend labels Jan 8, 2025
@JCantu248 JCantu248 self-assigned this Jan 8, 2025
hawkishpolicy
hawkishpolicy approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@hawkishpolicy hawkishpolicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

nickviola
nickviola approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cduhn17
cduhn17 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cduhn17 cduhn17 merged commit 62e93a0 into develop Jan 9, 2025
13 of 15 checks passed
@cduhn17 cduhn17 deleted the add_phony_pytest_to_makefile branch January 9, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkishpolicy hawkishpolicy hawkishpolicy approved these changes

@cduhn17 cduhn17 cduhn17 approved these changes

@nickviola nickviola nickviola approved these changes

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 is a code owner

@Matthew-Grayson Matthew-Grayson Awaiting requested review from Matthew-Grayson Matthew-Grayson is a code owner

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

Assignees

@JCantu248 JCantu248

Labels
backend test This issue or pull request adds or otherwise modifies test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JCantu248 @nickviola @cduhn17 @hawkishpolicy