-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IAM user login profile #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables console access for the user and creates an initial password, which must be changed the first time they login. This saves us from having to manually set up their initial password in the AWS console.
dav3r
added
the
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
label
Dec 18, 2024
mcdonnnj
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✔ I have one minor question for you.
dv4harr10
approved these changes
Dec 18, 2024
jsf9k
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one minor change request.
Co-authored-by: Jeremy Frasier <[email protected]>
jsf9k
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR adds IAM user login profiles in Terraform.
💭 Motivation and context
This change will eliminate the need to manually login to the AWS web console to enable a new user's console access and create their initial password. Those steps will now be handled automatically when this Terraform is applied.
Note that previously-created users must have their login profiles imported or else re-applying this Terraform will reset the console passwords of those users (see "Post-merge checklist" below).
🧪 Testing
I applied this Terraform in a fresh environment and confirmed that the users were all created along with their initial passwords. I also made sure that once a user changed their initial password, re-applying this Terraform did NOT reset their password.
I also tested the process of importing the user profile for previously created users and confirmed that it worked as expected with a command like this:
terraform import -var-file=my-env.tfvars aws_iam_user_login_profile.users[\"test.user\"] test.user
✅ Pre-approval checklist
to reflect the changes in this PR.
✅ Post-merge checklist
terraform import
IAM user profiles for users in all existing environments