-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3280: Review member permissions in registrar [LITTERBOX] #3325
base: main
Are you sure you want to change the base?
Conversation
🥳 Successfully deployed to developer sandbox litterbox. |
🥳 Successfully deployed to developer sandbox litterbox. |
1 similar comment
🥳 Successfully deployed to developer sandbox litterbox. |
🥳 Successfully deployed to developer sandbox litterbox. |
🥳 Successfully deployed to developer sandbox litterbox. |
🥳 Successfully deployed to developer sandbox litterbox. |
🥳 Successfully deployed to developer sandbox litterbox. |
This reverts commit f775818.
🥳 Successfully deployed to developer sandbox litterbox. |
🥳 Successfully deployed to developer sandbox litterbox. |
🥳 Successfully deployed to developer sandbox litterbox. |
🥳 Successfully deployed to developer sandbox litterbox. |
The linter is not happy about mark_safe, but since all the content is hard coded it is not a problem
🥳 Successfully deployed to developer sandbox litterbox. |
🥳 Successfully deployed to developer sandbox litterbox. |
…litterbox/3280-design-review
Some also were applied in the past commit https://cisa-corp.slack.com/archives/C087NN9UW5C/p1737677040679389
🥳 Successfully deployed to developer sandbox litterbox. |
1 similar comment
🥳 Successfully deployed to developer sandbox litterbox. |
🥳 Successfully deployed to developer sandbox litterbox. |
1 similar comment
🥳 Successfully deployed to developer sandbox litterbox. |
new_users = [] | ||
for user_data in users: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small refactor to add a placeholder email when none exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey mind adding an email to my fixtures analyst user while you're here ([email protected])
for user_data in users: | ||
username = user_data.get("username") | ||
id = user_data.get("id") | ||
first_name = user_data.get("first_name") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment: won't this now error if the name/ username and or lastname is not set in fixtures? We would probably want to avoid that.
🥳 Successfully deployed to developer sandbox litterbox. |
2 similar comments
🥳 Successfully deployed to developer sandbox litterbox. |
🥳 Successfully deployed to developer sandbox litterbox. |
Ticket
Resolves #3280
Changes
Context for reviewers
Most of the changes in this PR impact the member table, so that is a good place to start. The other two locations this hits are on the edit member domains table and the member domains table.
Setup
You will need to test the following:
Basically, all the changes denoted above will need to be tested. Given the volume of smaller changes, I would recommend doing this via a huddle as that would be more efficient. You will need to be in portfolio mode with the
organization_members
flag enabled.Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Validated user-facing changes as a developer
Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
References
Screenshots