Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3280: Review member permissions in registrar [LITTERBOX] #3325

Open
wants to merge 50 commits into
base: main
Choose a base branch
from

Conversation

zandercymatics
Copy link
Contributor

@zandercymatics zandercymatics commented Jan 10, 2025

Ticket

Resolves #3280

Changes

Context for reviewers

Most of the changes in this PR impact the member table, so that is a good place to start. The other two locations this hits are on the edit member domains table and the member domains table.

Setup

You will need to test the following:

  1. The members table
  2. The edit member domains table
  3. The member domains table

Basically, all the changes denoted above will need to be tested. Given the volume of smaller changes, I would recommend doing this via a huddle as that would be more efficient. You will need to be in portfolio mode with the organization_members flag enabled.

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

  • Met the acceptance criteria, or will meet them in a subsequent PR
  • Created/modified automated tests
  • Update documentation in READMEs and/or onboarding guide

Ensured code standards are met (Original Developer)

  • If any updated dependencies on Pipfile, also update dependencies in requirements.txt.
  • Interactions with external systems are wrapped in try/except
  • Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

  • Tag @dotgov-designers in this PR's Reviewers for design review. If code is not user-facing, delete design reviewer checklist
  • Verify new pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
  • Checked keyboard navigability
  • Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

  • Pulled this branch locally and tested it
  • Verified code meets all checks above. Address any checks that are not satisfied
  • Reviewed this code and left comments. Indicate if comments must be addressed before code is merged
  • Checked that all code is adequately covered by tests
  • Verify migrations are valid and do not conflict with existing migrations

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.

  • New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
  • Checked keyboard navigability
  • Meets all designs and user flows provided by design/product
  • Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
  • (Rarely needed) Tested as both an analyst and applicant user

As a designer reviewer, I have

Verified that the changes match the design intention

  • Checked that the design translated visually
  • Checked behavior. Comment any found issues or broken flows.
  • Checked different states (empty, one, some, error)
  • Checked for landmarks, page heading structure, and links

Validated user-facing changes as a designer

  • Checked keyboard navigability
  • Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
  • Tested with multiple browsers (check off which ones were used)
    • Chrome
    • Microsoft Edge
    • FireFox
    • Safari
  • (Rarely needed) Tested as both an analyst and applicant user

References

Screenshots

@zandercymatics zandercymatics changed the title [draft] #3280: Review member permissions in registrar [draft] #3280: Review member permissions in registrar - LITTERBOX Jan 10, 2025
@zandercymatics zandercymatics changed the title [draft] #3280: Review member permissions in registrar - LITTERBOX [draft] #3280: Review member permissions in registrar [LITTERBOX] Jan 10, 2025
Copy link

🥳 Successfully deployed to developer sandbox litterbox.

Copy link

🥳 Successfully deployed to developer sandbox litterbox.

1 similar comment
Copy link

🥳 Successfully deployed to developer sandbox litterbox.

Copy link

🥳 Successfully deployed to developer sandbox litterbox.

Copy link

🥳 Successfully deployed to developer sandbox litterbox.

Copy link

🥳 Successfully deployed to developer sandbox litterbox.

Copy link

🥳 Successfully deployed to developer sandbox litterbox.

This reverts commit f775818.
Copy link

🥳 Successfully deployed to developer sandbox litterbox.

Copy link

🥳 Successfully deployed to developer sandbox litterbox.

Copy link

🥳 Successfully deployed to developer sandbox litterbox.

Copy link

🥳 Successfully deployed to developer sandbox litterbox.

The linter is not happy about mark_safe, but since all the content is hard coded it is not a problem
Copy link

🥳 Successfully deployed to developer sandbox litterbox.

@zandercymatics zandercymatics changed the title [draft] #3280: Review member permissions in registrar [LITTERBOX] #3280: Review member permissions in registrar [LITTERBOX] Jan 23, 2025
@zandercymatics zandercymatics changed the title #3280: Review member permissions in registrar [LITTERBOX] [draft] #3280: Review member permissions in registrar [LITTERBOX] Jan 23, 2025
Copy link

🥳 Successfully deployed to developer sandbox litterbox.

Copy link

🥳 Successfully deployed to developer sandbox litterbox.

1 similar comment
Copy link

🥳 Successfully deployed to developer sandbox litterbox.

Copy link

🥳 Successfully deployed to developer sandbox litterbox.

1 similar comment
Copy link

🥳 Successfully deployed to developer sandbox litterbox.

@zandercymatics zandercymatics changed the title [draft] #3280: Review member permissions in registrar [LITTERBOX] #3280: Review member permissions in registrar [LITTERBOX] Jan 24, 2025
Comment on lines +364 to +365
new_users = []
for user_data in users:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small refactor to add a placeholder email when none exists

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey mind adding an email to my fixtures analyst user while you're here ([email protected])

@asaki222 asaki222 self-assigned this Jan 24, 2025
for user_data in users:
username = user_data.get("username")
id = user_data.get("id")
first_name = user_data.get("first_name")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment: won't this now error if the name/ username and or lastname is not set in fixtures? We would probably want to avoid that.

Copy link

🥳 Successfully deployed to developer sandbox litterbox.

2 similar comments
Copy link

🥳 Successfully deployed to developer sandbox litterbox.

Copy link

🥳 Successfully deployed to developer sandbox litterbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design: Review member permissions in registrar (limited scope)
3 participants