-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement of the Packer FMT + Packer Validate Hooks #4
base: develop
Are you sure you want to change the base?
Conversation
…e hook to take pkvars file as input
…e hook to take pkvars file as input
…e hook to take pkvars file as input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schniber We use a skeleton system touched on in our development guide. This allows us to keep our linter and testing configurations consistent across all of our repos using cisagov/action-lineage.
Although your PR includes some useful functionality, in the process you have steamrolled everything else in this project. As an additional note here, packer fmt
is only designed to service HCL2 configuration files as documented in the command help.
We would be happy to review a PR that adds the desired functionality, but we cannot accept a PR that intentionally creates discontinuity in one of our repositories.
Hello @mcdonnnj Regarding the pkrvars.hcl files, those are also considered as HCL2 files. Please feel free to revert back to me in case you need any additional details. Looking forward to hearing from you. Bests |
Enhancement of the Packer FMT + Packer Validate Hooks
🗣 Description
This PR enhances the following:
1- Packer fmt hook now not only checks but actually reformats all packer*.json or *.pkr.hcl. It also checks for *.pkrvars.hcl and if found formats them too.
2- Packer validate hook now accepts as input the *.pkrvars.hcl file which indicates to Packer with which parameters the Packer config can be validated with.
💭 Motivation and context
These enhancements are linked to the issue #3 I have created last week.
🧪 Testing
I have run tests on some packer configuration I am working on.
Additional details can be found on the README.md file that comes with this PR.
✅ Checklist
in code comments.
to reflect the changes in this PR.