Generic indexes #24
Merged
Generic indexes #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
paigerube14
reviewed
Apr 9, 2024
fmatch/matcher.py
Outdated
| ) | ||
| handler.setFormatter(formatter) | ||
| self.logger.addHandler(handler) | ||
| # Check if handlers are already added to avoid duplication |
There was a problem hiding this comment.
thinking we should keep this change as part of the separate pr here
There was a problem hiding this comment.
Yes it is handled in a seperate PR, added this to avoid confusion. I can roll-back a commit.
shashank-boyapally
force-pushed
the
generic-indexes
branch
from
9589e6e to
699f3f3
Compare
jtaleric
reviewed
Apr 9, 2024
| @@ -78,7 +78,7 @@ def test_get_uuid_by_metadata(matcher_instance): | |||
|
|
|||
|
|
|||
| def test_match_kube_burner(matcher_instance): | |||
| result = matcher_instance.match_kube_burner(["uuid1"]) | |||
| result = matcher_instance.match_kube_burner(["uuid1"],index="ospst-*") | |||
There was a problem hiding this comment.
for the test lets call out ospst-kube-burner (if that is the index) because we also have other indexes being dropped into ospst
There was a problem hiding this comment.
Since this is just a mockup test it really does not really matter what index I pass through.. it'll return the preset mock value instead of querying our es-instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
changed to generic index and verify certs added
Related Tickets & Documents
Checklist before requesting a review
Testing