Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get_field helper method #398

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

dev-ardi
Copy link
Contributor

This PR creates a helper method for FormData so that users don't have to pattern match for FormEntry::Field every time they want to use this. 99% of the time the passed arguments aren't files.

Copy link
Collaborator

@zebp zebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the formatting needs to be fixed.

@dev-ardi
Copy link
Contributor Author

LGTM but the formatting needs to be fixed.

Whoops, done :)

@dev-ardi
Copy link
Contributor Author

dev-ardi commented Oct 2, 2023

@zebp CI is failing after running cargo fmt, what's up with that?

@zebp
Copy link
Collaborator

zebp commented Oct 2, 2023

@zebp CI is failing after running cargo fmt, what's up with that?

CI is currently not passing on the revision of main your PR is based because of a new clippy lint, I updated main yesterdahy so you should be fine if you rebase the PR.

@kflansburg kflansburg requested a review from zebp November 8, 2023 15:23
@kflansburg kflansburg merged commit bb215a8 into cloudflare:main Nov 8, 2023
2 checks passed
jdon pushed a commit to jdon/workers-rs that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants