Add notebook for LAS to COPC Conversion #109
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,660 @@ | |||
| { | |||
There was a problem hiding this comment.
I'm not sure the print statement is the best way to explore the PDAL object. Can we do a more python oriented method showing maybe the top level or top 2 levels of keys.
Also explain if someone wants to work with the data what would they do next, read the array values?
Reply via ReviewNB
|
A few minor comments on the notebook itself. Bigger picture I think we need to hit all the core topics. Looking at https://guide.cloudnativegeo.org/cloud-optimized-geotiffs/cogs-examples.html creation (command line) and metadata but not actual cloud-optimized usage. Comparing that to https://guide.cloudnativegeo.org/zarr/zarr-in-practice.html which creates, explores, and demos access. This might be a follow up ticket related to #91 but I would consider adding simple usage to this example. |
|
Thanks @wildintellect
Those are great suggestions. I can add another intro notebook focusing only on accessing a LAS file and displaying metadata using PDAL (no COPC details). Then this notebook would serve the COPC creation, access and getting point cloud stats. |
|
@wildintellect can you please add @jsignell as a reviewer for this PR. Thank you. |
| @@ -0,0 +1,707 @@ | |||
| { | |||
There was a problem hiding this comment.
the "from this folder" link points to a specific version of the folder. Probably better to point to use a branch rather than a sha in the url.
Reply via ReviewNB
There was a problem hiding this comment.
Thank you. That's coming from the existing notebooks in the guide which were used as an initial template. Maybe it would be better to create separate issue for this to update all the notebooks.
| @@ -0,0 +1,707 @@ | |||
| { | |||
There was a problem hiding this comment.
It sounds like current versions of PDAL have just the pdal application and use the word "operations" to describe the different CLI commands.
Reply via ReviewNB
There was a problem hiding this comment.
Rephrased to make it clear. Thanks.
|
Thanks @jsignell for the comprehensive review. I've updated the notebook addressing your comments. Requesting re-review. |
|
@omshinde you're missing the navigation in cloud-optimized-geospatial-formats-guide/_quarto.yml Lines 54 to 55 in 8ff9f5f |
|
Thanks @wildintellect ..updated the navigation link |
* Clarify text about cloud opt allowing partial reads (#102) * Clean up imports * Add back newline * Adding writing COGs with Python notebook (#106) * Adding writing COGs with Python notebook * Addressing review comments * Add overview generation and set NoData values * Add description for overviews and predictors * update nodata value to -32768.0 * add in-text citation * update navigation link * Adding link to Project Pythia Kerchunk Cookbook (#108) * Clarify text about cloud opt allowing partial reads (#102) (#103) * adding ref to kerchunk cookbook * Add notebook for LAS to COPC Conversion (#109) * Add notebook for LAS to COPC Conversion * Adding cli based access info * Addressing review comments * update navigation link for COPC notebook * Minor updates for consistency in COPC full form * Update environment file * update pdal reader for copc * update copc:true check for validation --------- Co-authored-by: j08lue <[email protected]> Co-authored-by: Kyle Barron <[email protected]> Co-authored-by: Rajat Shinde <[email protected]> Co-authored-by: rsignell <[email protected]>
Ref #107
Tutorial for converting LiDAR LAS files to COPC format using PDAL -
Dataset used - G-LiHT Lidar Point Cloud V001