Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:support AWS bedrock calling claude #76

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

FamousMai
Copy link

@FamousMai FamousMai commented Jan 22, 2025

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

新增支持Aws bedrock方式调用cluade

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2025

CLA assistant check
All committers have signed the CLA.

@@ -38,7 +41,7 @@ import (
// - conf: Configuration for the Claude model
//
// Returns:
// - model.ChatModel: A chat model interface implementation
// - model.claude: A chat model interface implementation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model.claude 这个不对,是 model.ChatModel

awsConfig.WithCredentialsProvider(credentials.NewStaticCredentialsProvider(
config.AccessKey,
config.SecretAccessKey,
"",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个空字符串是啥参数?

AccessKey string

// SecretAccessKey is your Bedrock API Secret Access key
// Obtain from: https://docs.aws.amazon.com/bedrock/latest/userguide/getting-started.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文档信息是准确的吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants