Scroll into view sidebar #3376
Merged
Scroll into view sidebar #3376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
thetwopct
requested review from
caniszczyk,
seokho-son,
iamNoah1,
jihoon-seo and
nate-double-u
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jihoon-seo
approved these changes
Dec 30, 2024
seokho-son
approved these changes
Dec 30, 2024
|
Nice update, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Due to the length of the sidebar content, it was commented that finding the next/previous pages in the sidebar was difficult (see #3209). This PR keeps the current active item in view in the sidebar, so navigating should be easier.
Preview:
Screenshot-2024-12-29.--22.57.06.mp4
Related issue number or link (ex:
resolves #issue-number)Resolves #3209
Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfigby runninggit config --global alias.ci "commit -s".